User:Graememcc

  • Revision slug: User:Graememcc
  • Revision title: User:Graememcc
  • Revision id: 59561
  • Created:
  • Creator: Graememcc
  • Is current revision? No
  • Comment 1 words added, 1 words removed

Revision Content

Here, largely for my own gratification, is a list of bugs I've patched:

  • {{ Bug("46555") }} - "Select All" is enabled even when text field is empty
  • {{ Bug("215405") }} - Scroll position not remembered on pages with cache-control: no-store http header
  • {{ Bug("263683") }} - Find Bar "Highlight All" should use selection, not manipulate DOM
  • {{ Bug("318065") }} - Value is wrong during oninput for ctrl+z (undo) if text was blank before undo
  • {{ Bug("345339") }} - Revisit nsPresState
  • {{ Bug("348681") }} - Don't allow overlapping ranges in the selection
  • {{ Bug("393922") }} - Remove nsIDownloadProgressListener::onStatusChange and nsIDownloadListener::onLocationChange
  • {{ Bug("404572") }} - Get two different "Are you sure you want to quit?" dialogs when trying to quit during download
  • {{ Bug("408605") }} - Preference to control cross-session download behaviour
  • {{ Bug("415078") }} - nsWebShell.cpp attempts to fixup immutable URIs
  • {{ Bug("418874") }} - Undo function does not work in emptyText textboxes (e.g. Firefox search field, URL bar)
  • {{ Bug("429723") }} - Empty findbar turns red and "Phrase not found" is displayed when "Highlight all" is enabled and search term is removed
  • {{ Bug("449116") }} - Findbar highlighting should not explicitly repaint selection
  • {{ Bug("451203") }} - Unable to select text that has been highlighted by the find toolbar
  • {{ Bug("451204") }} - Highlighted text is white on white text on a yellow background, difficult to read
  • {{ Bug("451212") }} - "Highlight all" interferes with the look of disabled normal selection
  • {{ Bug("451286") }} - Highlight all does not seem to work at all across frames
  • {{ Bug("451232") }} - Setting ui.* color pref to empty string or removing pref doesn't immediately reset color to default
  • {{ Bug("451252") }} - "Highlight All" find selection not visible in elements that have -moz-user-select: none set
  • {{ Bug("451540") }} - Find highlighting in textboxes grows/decreases when editing matched word
  • {{ Bug("471319") }} - Undoing the last action of a textbox immediately after emptytext was displayed inserts a line feed (breaks search textbox)
  • {{ Bug("471722") }} - Plaintext editor redo handling code looks for incorrect type of bogus node
  • {{ Bug("471776") }} - Textboxes with emptytext shouldn't enable undo for display and deletion of empty text
  • {{ Bug("477631") }} - [Linux] Intermittent Chrome test_bug418874.xul failure
  • {{ Bug("483217") }} - prbool violation in /content/html/content/src/nsHTMLButtonElement.cpp
  • {{ Bug("483589") }} - PRBool problem in nsHTMLEditor::EnableExistingStylesheet
  • {{ Bug("483651") }} - Trailing <br> not removed when it should be
  • {{ Bug("493111") }} - "ASSERTION: Range index not returned"
  • {{ Bug("495153") }} - nsIEditor.removeEditActionListener exception in this case when unhighlighting after changing source of iframe
  • {{ Bug("502673") }} - Possible to crash with multiple document state listeners on the same object
  • {{ Bug("510575") }} - Selecting a table row and pasting in the editor crashes Firefox
  • {{ Bug("519695") }} - Assorted findbar nits
  • {{ Bug("562326") }} - bug451286_window.xul (used by test_bug451286.xul) randomly times out on the tinderbox if the HTML5 parser is enabled
  • {{ Bug("566251") }} - Findbar chrome tests should use SimpleTest.executeSoon rather than using nsIThreadManager directly
  • {{ Bug("566942") }} - nsTextFragment::SetTo can be slow
  • {{ Bug("640302") }} - Date comparisons in various add-on manager tests are fragile, and dependent on locale
  • {{ Bug("656131") }} - Typo in nsWebShellWindow::ConstrainToOpenerScreen
  • {{ Bug("682338") }} - nsXULPopupListener::HandleEvent intends to focus contextmenu target on platforms where it's shown on mousedown, but not those where it's shown on mouseup; been doing exact opposite since 2001
  • {{ Bug("682618") }} - test_contextmenu's IsCommandEnabled calls can be dispatched to the wrong element

 

The following patches are awaiting landing:

 

The following patches are awaiting review:

Revision Source

<p>Here, largely for my own gratification, is a list of bugs I've patched:</p>
<ul> <li>{{ Bug("46555") }} - "Select All" is enabled even when text field is empty</li> <li>{{ Bug("215405") }} - Scroll position not remembered on pages with cache-control: no-store http header</li> <li>{{ Bug("263683") }} - Find Bar "Highlight All" should use selection, not manipulate DOM</li> <li>{{ Bug("318065") }} - Value is wrong during oninput for ctrl+z (undo) if text was blank before undo</li> <li>{{ Bug("345339") }} - Revisit nsPresState</li> <li>{{ Bug("348681") }} - Don't allow overlapping ranges in the selection</li> <li>{{ Bug("393922") }} - Remove nsIDownloadProgressListener::onStatusChange and nsIDownloadListener::onLocationChange</li> <li>{{ Bug("404572") }} - Get two different "Are you sure you want to quit?" dialogs when trying to quit during download</li> <li>{{ Bug("408605") }} - Preference to control cross-session download behaviour</li> <li>{{ Bug("415078") }} - nsWebShell.cpp attempts to fixup immutable URIs</li> <li>{{ Bug("418874") }} - Undo function does not work in emptyText textboxes (e.g. Firefox search field, URL bar)</li> <li>{{ Bug("429723") }} - Empty findbar turns red and "Phrase not found" is displayed when "Highlight all" is enabled and search term is removed</li> <li>{{ Bug("449116") }} - Findbar highlighting should not explicitly repaint selection</li> <li>{{ Bug("451203") }} - Unable to select text that has been highlighted by the find toolbar</li> <li>{{ Bug("451204") }} - Highlighted text is white on white text on a yellow background, difficult to read</li> <li>{{ Bug("451212") }} - "Highlight all" interferes with the look of disabled normal selection</li> <li>{{ Bug("451286") }} - Highlight all does not seem to work at all across frames</li> <li>{{ Bug("451232") }} - Setting ui.* color pref to empty string or removing pref doesn't immediately reset color to default</li> <li>{{ Bug("451252") }} - "Highlight All" find selection not visible in elements that have -moz-user-select: none set</li> <li>{{ Bug("451540") }} - Find highlighting in textboxes grows/decreases when editing matched word</li> <li>{{ Bug("471319") }} - <span class="bz_default_hidden" id="summary_alias_container" style="display: inline;"><span id="short_desc_nonedit_display">Undoing the last action of a textbox immediately after emptytext was displayed inserts a line feed (breaks search textbox)</span></span></li> <li>{{ Bug("471722") }} - Plaintext editor redo handling code looks for incorrect type of bogus node</li> <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug("471776") }} - </span></span><span class="bz_default_hidden" id="summary_alias_container" style="display: inline;"><span id="short_desc_nonedit_display">Textboxes with emptytext shouldn't enable undo for display and deletion of empty text</span></span></li> <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug("477631") }} - [Linux] Intermittent Chrome test_bug418874.xul failure</span></span></li> <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug("483217") }} - prbool violation in /content/html/content/src/nsHTMLButtonElement.cpp</span></span></li> <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug("483589") }} - PRBool problem in nsHTMLEditor::EnableExistingStylesheet</span></span></li> <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug("483651") }} - Trailing &lt;br&gt; not removed when it should be</span></span></li> <li>{{ Bug("493111") }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">"ASSERTION: Range index not returned"</span></span></li> <li><span><span>{{ Bug("495153") }} - </span></span><span id="summary_alias_container"><span id="short_desc_nonedit_display">nsIEditor.removeEditActionListener exception in this case when unhighlighting after changing source of iframe</span></span></li> <li>{{ Bug("502673") }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Possible to crash with multiple document state listeners on the same object</span></span></li> <li>{{ Bug("510575") }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Selecting a table row and pasting in the editor crashes Firefox</span></span></li> <li>{{ Bug("519695") }} - Assorted findbar nits</li> <li>{{ Bug("562326") }} - bug451286<span><span><span class="bz_closed"><span><span>_window.xul (used by test_bug451286.xul) randomly times out on the tinderbox if the HTML5 parser is enabled</span></span></span></span></span></li> <li>{{ Bug("566251") }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Findbar chrome tests should use SimpleTest.executeSoon rather than using nsIThreadManager directly</span></span></li> <li>{{ Bug("566942") }} - nsTextFragment::SetTo can be slow</li> <li>{{ Bug("640302") }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Date comparisons in various add-on manager tests are fragile, and dependent on locale</span></span></li> <li>{{ Bug("656131") }} - Typo in nsWebShellWindow::ConstrainToOpenerScreen</li> <li><span id="summary_alias_container"><span id="short_desc_nonedit_display">{{ Bug("682338") }} - nsXULPopupListener::HandleEvent intends to focus contextmenu target on platforms where it's shown on mousedown, but not those where it's shown on mouseup; been doing exact opposite since 2001</span></span></li> <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug("682618") }} - </span></span>test_contextmenu's IsCommandEnabled calls can be dispatched to the wrong element</li>
</ul>
<p> </p>
<p>The following patches are awaiting landing:</p>
<p> </p>
<p>The following patches are awaiting review:</p>
Revert to this revision