User:Graememcc

  • Revision slug: User:Graememcc
  • Revision title: User:Graememcc
  • Revision id: 337083
  • Created:
  • Creator: Graememcc
  • Is current revision? Yes
  • Comment

Revision Content

Here, largely for my own gratification, is a list of bugs I've patched:

  • {{ Bug(46555) }} - "Select All" is enabled even when text field is empty
  • {{ Bug(215405) }} - Scroll position not remembered on pages with cache-control: no-store http header
  • {{ Bug(263683) }} - Find Bar "Highlight All" should use selection, not manipulate DOM
  • {{ Bug(318065) }} - Value is wrong during oninput for ctrl+z (undo) if text was blank before undo
  • {{ Bug(345339) }} - Revisit nsPresState
  • {{ Bug(348681) }} - Don't allow overlapping ranges in the selection
  • {{ Bug(393922) }} - Remove nsIDownloadProgressListener::onStatusChange and nsIDownloadListener::onLocationChange
  • {{ Bug(404572) }} - Get two different "Are you sure you want to quit?" dialogs when trying to quit during download
  • {{ Bug(408605) }} - Preference to control cross-session download behaviour
  • {{ Bug(409624)}} - FastFind not cleared when doing Clear private data
  • {{ Bug(415078) }} - nsWebShell.cpp attempts to fixup immutable URIs
  • {{ Bug(418874) }} - Undo function does not work in emptyText textboxes (e.g. Firefox search field, URL bar)
  • {{ Bug(429723) }} - Empty findbar turns red and "Phrase not found" is displayed when "Highlight all" is enabled and search term is removed
  • {{ Bug(449116) }} - Findbar highlighting should not explicitly repaint selection
  • {{ Bug(451203) }} - Unable to select text that has been highlighted by the find toolbar
  • {{ Bug(451204) }} - Highlighted text is white on white text on a yellow background, difficult to read
  • {{ Bug(451212) }} - "Highlight all" interferes with the look of disabled normal selection
  • {{ Bug(451286) }} - Highlight all does not seem to work at all across frames
  • {{ Bug(451232) }} - Setting ui.* color pref to empty string or removing pref doesn't immediately reset color to default
  • {{ Bug(451252) }} - "Highlight All" find selection not visible in elements that have -moz-user-select: none set
  • {{ Bug(451540) }} - Find highlighting in textboxes grows/decreases when editing matched word
  • {{ Bug(471319) }} - Undoing the last action of a textbox immediately after emptytext was displayed inserts a line feed (breaks search textbox)
  • {{ Bug(471722) }} - Plaintext editor redo handling code looks for incorrect type of bogus node
  • {{ Bug(471776) }} - Textboxes with emptytext shouldn't enable undo for display and deletion of empty text
  • {{ Bug(477631) }} - [Linux] Intermittent Chrome test_bug418874.xul failure
  • {{ Bug(483217) }} - prbool violation in /content/html/content/src/nsHTMLButtonElement.cpp
  • {{ Bug(483589) }} - PRBool problem in nsHTMLEditor::EnableExistingStylesheet
  • {{ Bug(483651) }} - Trailing <br> not removed when it should be
  • {{ Bug(493111) }} - "ASSERTION: Range index not returned"
  • {{ Bug(495153) }} - nsIEditor.removeEditActionListener exception in this case when unhighlighting after changing source of iframe
  • {{ Bug(502673) }} - Possible to crash with multiple document state listeners on the same object
  • {{ Bug(510575) }} - Selecting a table row and pasting in the editor crashes Firefox
  • {{ Bug(519695) }} - Assorted findbar nits
  • {{ Bug(562326) }} - bug451286_window.xul (used by test_bug451286.xul) randomly times out on the tinderbox if the HTML5 parser is enabled
  • {{ Bug(566251) }} - Findbar chrome tests should use SimpleTest.executeSoon rather than using nsIThreadManager directly
  • {{ Bug(566942) }} - nsTextFragment::SetTo can be slow
  • {{ Bug(640302) }} - Date comparisons in various add-on manager tests are fragile, and dependent on locale
  • {{ Bug(656131) }} - Typo in nsWebShellWindow::ConstrainToOpenerScreen
  • {{ Bug(663585) }} - Push hooks should print out hg url for the changeset
  • {{ Bug(682338) }} - nsXULPopupListener::HandleEvent intends to focus contextmenu target on platforms where it's shown on mousedown, but not those where it's shown on mouseup; been doing exact opposite since 2001
  • {{ Bug(682618) }} - test_contextmenu's IsCommandEnabled calls can be dispatched to the wrong element
  • {{ Bug(693029) }} - Ctrl+F shouldn't work to open Find toolbar in about:permissions for realz this time.
  • {{ Bug(724513) }} - Startupcache can load invalid cache if unable to delete startupCache file
  • {{ Bug(736358) }} - Do not prompt users to "open the add-ons manager" when a restartless add-on finishes installing
  • {{ Bug(740784) }} - Undo (Ctrl+z) in textarea adding a newline (\n) to the text
  • {{ Bug(747163) }} - TelemetryHistogramType returns failure for HISTOGRAM_FLAG
  • {{ Bug(747379) }} - Cloning a flag histogram with Telemetry::HistogramFrom breaks the "only one count" invariant
  • {{ Bug(764207) }} - Tryserver pushes should output TBPL link for the push
  • {{ Bug(766181) }} - Need an extra null check for aOutIndex in Selection::AddItem
  • {{ Bug(778231) }} - Add a button to auto-post csets to bugs (Partial fix - still some WIP)
  • {{ Bug(785051) }} - Display tree 'motd' field after 'reason', once added to TreeStatus
  • {{ Bug(789576) }} - Automatically linkify "bug XXXXXX" when present in tree status reason/motd
  • {{ Bug(802718) }} - Manually restore window at end of browser_minimize to avoid breaking rest of suite if test fails

TreeStatus

m-cMerge

I am the author of m-cMerge, the tool inbound sheriffs use for taking care of post-merge Bugzilla administrivia. You can read about m-cMerge here, and view my contributions to it here.

Badger

Badger is a proof-of-concept exploring the idea of issuing Open Badges for Firefox contributions.

Revision Source

<p>Here, largely for my own gratification, is a list of bugs I've patched:</p>
<ul>
  <li>{{ Bug(46555) }} - "Select All" is enabled even when text field is empty</li>
  <li>{{ Bug(215405) }} - Scroll position not remembered on pages with cache-control: no-store http header</li>
  <li>{{ Bug(263683) }} - Find Bar "Highlight All" should use selection, not manipulate DOM</li>
  <li>{{ Bug(318065) }} - Value is wrong during oninput for ctrl+z (undo) if text was blank before undo</li>
  <li>{{ Bug(345339) }} - Revisit nsPresState</li>
  <li>{{ Bug(348681) }} - Don't allow overlapping ranges in the selection</li>
  <li>{{ Bug(393922) }} - Remove nsIDownloadProgressListener::onStatusChange and nsIDownloadListener::onLocationChange</li>
  <li>{{ Bug(404572) }} - Get two different "Are you sure you want to quit?" dialogs when trying to quit during download</li>
  <li>{{ Bug(408605) }} - Preference to control cross-session download behaviour</li>
  <li>{{ Bug(409624)}} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">FastFind not cleared when doing Clear private data</span></span></li>
  <li>{{ Bug(415078) }} - nsWebShell.cpp attempts to fixup immutable URIs</li>
  <li>{{ Bug(418874) }} - Undo function does not work in emptyText textboxes (e.g. Firefox search field, URL&nbsp;bar)</li>
  <li>{{ Bug(429723) }} - Empty findbar turns red and "Phrase not found" is displayed when "Highlight&nbsp;all" is enabled and search term is removed</li>
  <li>{{ Bug(449116) }} - Findbar highlighting should not explicitly repaint selection</li>
  <li>{{ Bug(451203) }} - Unable to select text that has been highlighted by the find toolbar</li>
  <li>{{ Bug(451204) }} - Highlighted text is white on white text on a yellow background, difficult to read</li>
  <li>{{ Bug(451212) }} - "Highlight all"&nbsp;interferes with the look of disabled normal selection</li>
  <li>{{ Bug(451286) }} - Highlight all does not seem to work at all across frames</li>
  <li>{{ Bug(451232) }} - Setting ui.* color pref to empty string or removing pref doesn't immediately reset color to default</li>
  <li>{{ Bug(451252) }} - "Highlight All" find selection not visible in elements that have -moz-user-select: none set</li>
  <li>{{ Bug(451540) }} - Find highlighting in textboxes grows/decreases when editing matched word</li>
  <li>{{ Bug(471319) }} - <span class="bz_default_hidden" id="summary_alias_container" style="display: inline;"><span id="short_desc_nonedit_display">Undoing the last action of a textbox immediately after emptytext was displayed inserts a line feed (breaks search textbox)</span></span></li>
  <li>{{ Bug(471722) }}&nbsp;- Plaintext editor redo handling code looks for incorrect type of bogus node</li>
  <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug(471776) }} - </span></span><span class="bz_default_hidden" id="summary_alias_container" style="display: inline;"><span id="short_desc_nonedit_display">Textboxes with emptytext shouldn't enable undo for display and deletion of empty text</span></span></li>
  <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug(477631) }} - [Linux] Intermittent Chrome test_bug418874.xul failure</span></span></li>
  <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug(483217) }} - prbool violation in /content/html/content/src/nsHTMLButtonElement.cpp</span></span></li>
  <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug(483589) }} - PRBool problem in nsHTMLEditor::EnableExistingStylesheet</span></span></li>
  <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug(483651) }} - Trailing &lt;br&gt; not removed when it should be</span></span></li>
  <li>{{ Bug(493111) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">"ASSERTION: Range index not returned"</span></span></li>
  <li><span><span>{{ Bug(495153) }} - </span></span><span id="summary_alias_container"><span id="short_desc_nonedit_display">nsIEditor.removeEditActionListener exception in this case when unhighlighting after changing source of iframe</span></span></li>
  <li>{{ Bug(502673) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Possible to crash with multiple document state listeners on the same object</span></span></li>
  <li>{{ Bug(510575) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Selecting a table row and pasting in the editor crashes Firefox</span></span></li>
  <li>{{ Bug(519695) }} - Assorted findbar nits</li>
  <li>{{ Bug(562326) }} - bug451286<span><span><span class="bz_closed"><span><span>_window.xul (used by test_bug451286.xul) randomly times out on the tinderbox if the HTML5 parser is enabled</span></span></span></span></span></li>
  <li>{{ Bug(566251) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Findbar chrome tests should use SimpleTest.executeSoon rather than using nsIThreadManager directly</span></span></li>
  <li>{{ Bug(566942) }} - nsTextFragment::SetTo can be slow</li>
  <li>{{ Bug(640302) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Date comparisons in various add-on manager tests are fragile, and dependent on locale</span></span></li>
  <li>{{ Bug(656131) }} - Typo in nsWebShellWindow::ConstrainToOpenerScreen</li>
  <li>{{ Bug(663585) }} - P<span id="summary_alias_container"><span id="short_desc_nonedit_display">ush hooks should print out hg url for the changeset</span></span></li>
  <li><span id="summary_alias_container"><span id="short_desc_nonedit_display">{{ Bug(682338) }} - nsXULPopupListener::HandleEvent intends to focus contextmenu target on platforms where it's shown on mousedown, but not those where it's shown on mouseup; been doing exact opposite since 2001</span></span></li>
  <li><span class="bz_default_hidden" style="display: inline;"><span>{{ Bug(682618) }} - </span></span>test_contextmenu's IsCommandEnabled calls can be dispatched to the wrong element</li>
  <li>{{ Bug(693029) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Ctrl+F shouldn't work to open Find toolbar in about:permissions for realz this time.</span></span></li>
  <li>{{ Bug(724513) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Startupcache can load invalid cache if unable to delete startupCache file</span></span></li>
  <li>{{ Bug(736358) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Do not prompt users to "open the add-ons manager" when a restartless add-on finishes installing</span></span></li>
  <li>{{ Bug(740784) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Undo (Ctrl+z) in textarea adding a newline (\n) to the text</span></span></li>
  <li>{{ Bug(747163) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">TelemetryHistogramType returns failure for HISTOGRAM_FLAG</span></span></li>
  <li>{{ Bug(747379) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Cloning a flag histogram with Telemetry::HistogramFrom breaks the "only one count" invariant</span></span></li>
  <li>{{ Bug(764207) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Tryserver pushes should output TBPL link for the push</span></span></li>
  <li>{{ Bug(766181) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Need an extra null check for aOutIndex in Selection::AddItem</span></span></li>
  <li>{{ Bug(778231) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Add a button to auto-post csets to bugs (Partial fix - still some WIP)</span></span></li>
  <li>{{ Bug(785051) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Display tree 'motd' field after 'reason', once added to TreeStatus</span></span></li>
  <li>{{ Bug(789576) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Automatically linkify "bug XXXXXX" when present in tree status reason/motd</span></span></li>
  <li>{{ Bug(802718) }} - <span id="summary_alias_container"><span id="short_desc_nonedit_display">Manually restore window at end of browser_minimize to avoid breaking rest of suite if test fails</span></span></li>
</ul>
<h4 id="TreeStatus">TreeStatus</h4>
<ul>
  <li><a href="https://github.com/catlee/treestatus/commit/2db5a50013dd16caae0864923bc35a7aae439f23" title="https://github.com/catlee/treestatus/commit/2db5a50013dd16caae0864923bc35a7aae439f23">Add "Message of the day" field to trees</a></li>
  <li><a href="https://github.com/catlee/treestatus/commit/53e9e1158d234cfc1ba51c107f6b582f4e90accd" title="https://github.com/catlee/treestatus/commit/53e9e1158d234cfc1ba51c107f6b582f4e90accd">A prettier TreeStatus</a></li>
</ul>
<h4 id="m-cMerge">m-cMerge</h4>
<p>I am the author of <a href="http://www.graememcc.co.uk/m-cmerge" title="http://www.graememcc.co.uk/m-cmerge">m-cMerge</a>, the tool inbound sheriffs use for taking care of post-merge Bugzilla administrivia. You can read about m-cMerge <a href="http://www.graememcc.co.uk/tag/m-cmerge/" title="http://www.graememcc.co.uk/tag/m-cmerge/">here</a>, and view my contributions to it <a href="https://bitbucket.org/graememcc/m-cmerge/changesets" title="https://bitbucket.org/graememcc/m-cmerge/changesets">here</a>.</p>
<h4>Badger</h4>
<p><a href="http://www.graememcc.co.uk/badger" title="http://www.graememcc.co.uk/badger">Badger</a> is a proof-of-concept exploring the idea of issuing Open Badges for Firefox contributions.</p>
Revert to this revision