mozilla

Revision 126802 of document.loadOverlay

  • Revision slug: Talk:DOM/document.loadOverlay
  • Revision title: document.loadOverlay
  • Revision id: 126802
  • Created:
  • Creator: Nickolay
  • Is current revision? No
  • Comment

Revision Content

The phrase about observer being optional came straight from the IDL actually. --Nickolay 08:47, 30 November 2005 (PST)

I actually noticed this when patching a small crasher in loadOverlay, tho it happened after I submitted the changes here. The "optional" part's definitely wrong, tho (testcase). I'm not even sure that you can have optional parameters in XPCOM. --Waldo 13:23, 30 November 2005 (PST)
Optional in the sense that null may be passed.
I remember a bug that was caused by the fact that current implementation doesn't deal well with null observers, and agree with your edit; just had to mention that IDL says otherwise. --Nickolay 14:04, 30 November 2005 (PST)

Revision Source

<p>The phrase about observer being optional came straight from the IDL actually. --<a href="User:Nickolay">Nickolay</a> 08:47, 30 November 2005 (PST)
</p>
<dl><dd>I actually noticed this when patching a small crasher in loadOverlay, tho it happened after I submitted the changes here. The "optional" part's definitely wrong, tho (<a class="external" href="http://whereswalden.com/files/mozilla/testcases/xuloverlay/omittedObserver.xul">testcase</a>). I'm not even sure that you can have optional parameters in XPCOM. --<a href="User:Waldo">Waldo</a> 13:23, 30 November 2005 (PST)
<dl><dd>Optional in the sense that null may be passed.<br> I remember a bug that was caused by the fact that current implementation doesn't deal well with null observers, and agree with your edit; just had to mention that IDL says otherwise. --<a href="User:Nickolay">Nickolay</a> 14:04, 30 November 2005 (PST)
</dd></dl>
</dd></dl>
Revert to this revision