Talk:Getting your patch in the tree

From MDC

[edit] "Carrying over" reviews

I disagree with some of the changes made in this edit. Specifically, the "set the flag to + yourself" part, which encourages people to "carry-over" review on subsequent patches. I think that "carrying over" should be discouraged, because it makes it harder to see who actually reviewed the patch by cluttering the bug with flags set by people other than the reviewers, e.g. bug 374862, and encourages people to set flags that they're not otherwise allowed to set.

I don't see any benefit to marking the flag when it's clear that the review "carries over" based on the reviewers comment. If we want to make the task of comparing patches and ensuring the comments are addressed, we should encourage patch submitters to use consistent patch filenames/descriptions that include a revision number (e.g. patch-v1.diff, patch-v2.diff, or 123456.1.diff/123456.2.diff).

-- gavin 10:28, 31 January 2008 (PST)